You’re not the Pete Thomas who plays and teaches sax, are you?
In any event, it sounds like you’d meet the conditions for a visa (VLS-TS) and, after that, for Titre de Séjour. That’s renewable (at the moment) repeatedly.
Applying for a visa is straightforward as long as you’re methodical.
Citizenship is unlikely to be within reach, given the recent changes in the law, though who knows what might happen in the future?
I think it quite safe to say that with the anticipated tax to be had from you, France will welcome you as a resident with open arms I will send you a card of a financial lawyer who can make it happen…
But the bit that is more complex and potentially needs professional advice is the change to French tax and also French succession laws. Once you arrive planning to be resident you will be taxed on your world wide income and have to declare all bank accounts, including digital.
Succession laws are also different so if you have a blended family look into this.
Also look into ISF, income sur la fortune, which may apply to you after 5 years here and us an extra tax.